optimize fail status

beike/API/Controllers/Admin/ProductController.php

@@ -63,7 +63,7 @@ class ProductController
      * 创建商品
      *
      * @param ProductRequest $request
-     * @return array
+     * @return mixed
      */
     public function store(ProductRequest $request)
     {
@@ -88,7 +88,7 @@ class ProductController
      *
      * @param ProductRequest $request
      * @param Product        $product
-     * @return array
+     * @return mixed
      */
     public function update(ProductRequest $request, Product $product)
     {

beike/Helpers.php

@@ -11,6 +11,7 @@ use Beike\Repositories\CurrencyRepo;
 use Beike\Repositories\LanguageRepo;
 use Beike\Services\CurrencyService;
 use Illuminate\Database\Eloquent\Builder;
+use Illuminate\Http\JsonResponse;
 use Illuminate\Support\Collection;
 use Illuminate\Support\Facades\Route;
 use Illuminate\Support\Facades\Session;
@@ -520,26 +521,28 @@ function quantity_format($quantity)
 /**
  * 返回json序列化结果
  */
-function json_success($message, $data = [], $status=422): \Illuminate\Http\JsonResponse
+function json_success($message, $data = [])
 {
-    $data = [
+    return [
         'status'  => 'success',
         'message' => $message,
         'data'    => $data,
     ];
-    return response()->json($data, $status);
+
 }
 
 /**
  * 返回json序列化结果
  */
-function json_fail($message, $data = []): array
+function json_fail($message, $data = [], $status = 422): JsonResponse
 {
-    return [
+    $data = [
         'status'  => 'fail',
         'message' => $message,
         'data'    => $data,
     ];
+
+    return response()->json($data, $status);
 }
 
 if (! function_exists('sub_string')) {